Match index adds as well as base

Match index adds as well as base

BUG=
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=69e9290c092e551a130e6c3a1477a6e97c54212d

[sehr, 2015-11-04 20:58:33]

Description was changed from

==========
Match index adds as well as base

BUG=
==========

to

==========
Match index adds as well as base

BUG=
==========

[sehr, 2015-11-04 20:58:33]

sehr@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, stichnot@chromium.org

[sehr, 2015-11-04 20:59:09]

Catches a small number of cases missed previously.  No significant perf impact.

[Jim Stichnoth, 2015-11-04 21:25:11]

lgtm

https://codereview.chromium.org/1421603003/diff/1/src/IceTargetLoweringX86Bas...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1421603003/diff/1/src/IceTargetLoweringX86Bas...
src/IceTargetLoweringX86BaseImpl.h:4529: if (Shift == 0 &&
This "Shift == 0" is inconsistent with "(Shift == 0)" above.  Make them
consistent?  (I personally prefer without parentheses here.)

[sehr, 2015-11-04 22:44:43]

Thanks for the review.

https://codereview.chromium.org/1421603003/diff/1/src/IceTargetLoweringX86Bas...
File src/IceTargetLoweringX86BaseImpl.h (right):

https://codereview.chromium.org/1421603003/diff/1/src/IceTargetLoweringX86Bas...
src/IceTargetLoweringX86BaseImpl.h:4529: if (Shift == 0 &&
On 2015/11/04 21:25:11, stichnot wrote:
> This "Shift == 0" is inconsistent with "(Shift == 0)" above.  Make them
> consistent?  (I personally prefer without parentheses here.)

Removed, as suggested.

[sehr, 2015-11-04 22:46:34]

Committed patchset #2 (id:20001) manually as
69e9290c092e551a130e6c3a1477a6e97c54212d (presubmit successful).