Issue 1421593004: Change QuicFramer::BuildDataPacket to return a length instead of QuicPacket* in order to reduce mem…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1421593004: Change QuicFramer::BuildDataPacket to return a length instead of QuicPacket* in order to reduce mem… (Closed)

Created:
5 years, 2 months ago by alyssar1

Modified:
5 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@105596142

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change QuicFramer::BuildDataPacket to return a length instead of QuicPacket* in order to reduce memory allocations. Estimated to save ~0.3% of CPU. Merge internal change: 105596667 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -44 lines)			Patch
M	net/quic/quic_framer.h	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	net/quic/quic_framer.cc	View	4 chunks	+16 lines, -22 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	1 chunk	+18 lines, -10 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Depends on Patchset:

Issue 1421633002 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages