Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1421583002: Reland "[heap] Divide available memory upon compaction tasks" (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Divide available memory upon compaction tasks" This reverts commit a31cef44dcd79ae0ea53d83b70b5af130a499754. Original message: [heap] Divide available memory upon compaction tasks - Fairly (round-robin) divide available memory upon compaction tasks. - Ensure an upper limit (of memory) since dividing is O(n) for n free-space nodes. - Refill from free lists managed by sweeper once a compaction space becomes empty. Assumption for dividing memory: Memory in the free lists is sparse upon starting compaction (which means that only few nodes are available), except for memory reducer GCs, which happen in idle time though (so it's less of a problem). BUG=chromium:524425 LOG=N Committed: https://crrev.com/218c06e803bca6f22dc23fe305dd2bad77edf1e1 Cr-Commit-Position: refs/heads/master@{#31443}

Patch Set 1 : base #

Patch Set 2 : s/+1/+kPointerSize/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -66 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +14 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 4 chunks +7 lines, -30 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +31 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 6 chunks +136 lines, -8 lines 0 comments Download
M test/cctest/heap-tester.h View 2 chunks +32 lines, -11 lines 0 comments Download
M test/cctest/test-spaces.cc View 5 chunks +156 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-10-21 13:41:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421583002/20001
5 years, 2 months ago (2015-10-21 13:41:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-21 14:21:05 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 14:21:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/218c06e803bca6f22dc23fe305dd2bad77edf1e1
Cr-Commit-Position: refs/heads/master@{#31443}

Powered by Google App Engine
This is Rietveld 408576698