Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1421553017: Remove *.mojom.dart from //{,mojo/public/dart/}.gitignore, stop copying during build (Closed)

Created:
5 years, 1 month ago by jamesr
Modified:
5 years, 1 month ago
Reviewers:
zra, Cutch
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove *.mojom.dart from //{,mojo/public/dart/}.gitignore, stop copying during build We shouldn't have any mojom.dart files in the tree right now. When we do we do not want to be .gitignore'ing them. We also should not be copying files from the build directory into the source directory during a build. In practice this seemed to only be copying files into //mojo/public/dart/mojo/sdk_ext/lib/ for reasons not entirely clear to me. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/235f99dc51bbeb1c00aa7480443c7eb98d0a858a

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/dart/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/dart_pkg.py View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jamesr
John - sending this out so I can start figuring out how to deal with ...
5 years, 1 month ago (2015-11-11 20:44:47 UTC) #4
Cutch
lgtm
5 years, 1 month ago (2015-11-11 20:45:31 UTC) #5
zra
It looks like there's also a *.mojom.dart entry in //mojo/public/dart/.gitignore
5 years, 1 month ago (2015-11-11 20:53:27 UTC) #7
zra
On 2015/11/11 20:53:27, zra wrote: > It looks like there's also a *.mojom.dart entry in ...
5 years, 1 month ago (2015-11-11 20:53:56 UTC) #8
jamesr
5 years, 1 month ago (2015-11-11 21:10:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
235f99dc51bbeb1c00aa7480443c7eb98d0a858a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698