Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1421553016: scale with conversion using 2 steps with unittest (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin, fbarchard
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

scale with conversion using 2 steps with unittest a prototype function to implement the yuv to rgb with conversion and scale. replace with 1 step function in future version, using same API. R=harryjin@google.com BUG=libyuv:471 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/60adcbaf323cfa6b7a2ea408f3c904341a1998c7

Patch Set 1 #

Patch Set 2 : bump version to 1537 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -3 lines) Patch
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/scale_argb.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/libyuv/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/scale_argb.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M unit_test/scale_argb_test.cc View 1 2 chunks +154 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
fbarchard1
5 years, 1 month ago (2015-11-10 20:42:52 UTC) #1
harryjin
lgtm
5 years, 1 month ago (2015-11-10 21:19:44 UTC) #2
fbarchard
The test as function both need improvements, but its a starting point. YUVToRGBScaleUp (3513 ms) ...
5 years, 1 month ago (2015-11-13 19:23:21 UTC) #4
fbarchard1
5 years, 1 month ago (2015-11-13 19:26:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
60adcbaf323cfa6b7a2ea408f3c904341a1998c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698