Make SVGLength wrap a CSSPrimitiveValue.

third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index 171269f4704087fde1e30b4b2bd7421fe71b7abd..5d69ea0845c5f6dda51903c6f38b8bf45f75c66e 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -278,6 +278,7 @@ static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> consumeLength(CSSParserTokenRan
         case CSSPrimitiveValue::UnitType::Inches:
         case CSSPrimitiveValue::UnitType::Points:
         case CSSPrimitiveValue::UnitType::Picas:
+        case CSSPrimitiveValue::UnitType::UserUnits:
         case CSSPrimitiveValue::UnitType::ViewportWidth:
         case CSSPrimitiveValue::UnitType::ViewportHeight:
         case CSSPrimitiveValue::UnitType::ViewportMin:
@@ -291,9 +292,12 @@ static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> consumeLength(CSSParserTokenRan
         return cssValuePool().createValue(range.consumeIncludingWhitespace().numericValue(), token.unitType());
     }
     if (token.type() == NumberToken) {
+        fprintf(stderr, "consumeLength() parsed %g\n", token.numericValue());

[Timothy Loh, 2015/11/04 00:33:44]

More debugging code ;)

[Stephen Chennney, 2015/11/04 18:04:47]

Done.

         if (!shouldAcceptUnitlessValues(token.numericValue(), cssParserMode, unitless)
             || (valueRange == ValueRangeNonNegative && token.numericValue() < 0))
             return nullptr;
+        if (cssParserMode == SVGAttributeMode)

[fs, 2015/11/03 22:40:14]

Maybe do something similar here as in the fast-path parser, i.e:

...UnitType unitType = ...Pixels;
if (<svg-mode>)
    unitType = ...UserUnits;
return cssValuePool().createValue(..., unitType);

or some variation thereof.

[Stephen Chennney, 2015/11/04 18:04:47]

Done.

+            return cssValuePool().createValue(range.consumeIncludingWhitespace().numericValue(), CSSPrimitiveValue::UnitType::UserUnits);
         return cssValuePool().createValue(range.consumeIncludingWhitespace().numericValue(), CSSPrimitiveValue::UnitType::Pixels);
     }
     CalcParser calcParser(range, valueRange);