third_party/WebKit/Source/core/svg/SVGLengthList.cpp - Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthList.cpp

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLengthList.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthList.cpp b/third_party/WebKit/Source/core/svg/SVGLengthList.cpp

index 1fadc5eb0daf1e93703d6ac7abf0e9bcbd858d47..9124271531807ac15b2ef23bbbb8108ef7b5ba25 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthList.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLengthList.cpp

@@ -152,11 +152,11 @@ void SVGLengthList::calculateAnimatedValue(SVGAnimationElement* animationElement

for (size_t i = 0; i < toLengthListSize; ++i) {

float animatedNumber = at(i)->value(lengthContext);

- SVGLengthType unitType = toList->at(i)->unitType();

+ CSSPrimitiveValue::UnitType unitType = toList->at(i)->typeWithCalcResolved();

float effectiveFrom = 0;

if (fromLengthListSize) {

if (percentage < 0.5)

- unitType = fromList->at(i)->unitType();

+ unitType = fromList->at(i)->typeWithCalcResolved();

effectiveFrom = fromList->at(i)->value(lengthContext);

}

float effectiveTo = toList->at(i)->value(lengthContext);