third_party/WebKit/Source/core/svg/SVGLengthContext.h - Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthContext.h

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added expectation Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLengthContext.h

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthContext.h b/third_party/WebKit/Source/core/svg/SVGLengthContext.h

index 93a406481b6c417e09aa3425938a537255036ff4..ff73b7615083d8b626c0e6c9af5811222c7317d4 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthContext.h

+++ b/third_party/WebKit/Source/core/svg/SVGLengthContext.h

@@ -20,6 +20,7 @@

#ifndef SVGLengthContext_h

#define SVGLengthContext_h

+#include "core/css/CSSPrimitiveValue.h"

#include "core/svg/SVGUnitTypes.h"

#include "platform/Length.h"

#include "platform/geometry/FloatRect.h"

@@ -68,8 +69,8 @@ public:

static FloatPoint resolvePoint(const SVGElement*, SVGUnitTypes::SVGUnitType, const SVGLength& x, const SVGLength& y);

static float resolveLength(const SVGElement*, SVGUnitTypes::SVGUnitType, const SVGLength&);

- float convertValueToUserUnits(float, SVGLengthMode, SVGLengthType fromUnit) const;

- float convertValueFromUserUnits(float, SVGLengthMode, SVGLengthType toUnit) const;

+ float convertValueToUserUnits(float, SVGLengthMode, CSSPrimitiveValue::UnitType fromUnit) const;

+ float convertValueFromUserUnits(float, SVGLengthMode, CSSPrimitiveValue::UnitType toUnit) const;

float valueForLength(const UnzoomedLength&, SVGLengthMode = SVGLengthMode::Other) const;

float valueForLength(const Length&, const ComputedStyle&, SVGLengthMode = SVGLengthMode::Other) const;