Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.h

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added expectation Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGLength.h
diff --git a/third_party/WebKit/Source/core/svg/SVGLength.h b/third_party/WebKit/Source/core/svg/SVGLength.h
index 4662cbb5cec42159954584980ba9ebf15b3136bf..171cd286aa7514b5fbc16b5c07135170c4fda246 100644
--- a/third_party/WebKit/Source/core/svg/SVGLength.h
+++ b/third_party/WebKit/Source/core/svg/SVGLength.h
@@ -47,23 +47,17 @@ public:
return adoptRefWillBeNoop(new SVGLength(mode));
}
+ DECLARE_VIRTUAL_TRACE();
+
PassRefPtrWillBeRawPtr<SVGLength> clone() const;
PassRefPtrWillBeRawPtr<SVGPropertyBase> cloneForAnimation(const String&) const override;
- SVGLengthType unitType() const { return static_cast<SVGLengthType>(m_unitType); }
+ CSSPrimitiveValue::UnitType typeWithCalcResolved() const { return m_value->typeWithCalcResolved(); }
CSSPrimitiveValue::UnitType cssUnitTypeQuirk() const
{
- if (m_unitType == LengthTypeNumber)
- return CSSPrimitiveValue::UnitType::Pixels;
-
- if (m_unitType == LengthTypeREMS)
- return CSSPrimitiveValue::UnitType::Rems;
- if (m_unitType == LengthTypeCHS)
- return CSSPrimitiveValue::UnitType::Chs;
-
- return static_cast<CSSPrimitiveValue::UnitType>(m_unitType);
+ return m_value->typeWithCalcResolved();
}
- void setUnitType(SVGLengthType);
+ void setUnitType(CSSPrimitiveValue::UnitType);
SVGLengthMode unitMode() const { return static_cast<SVGLengthMode>(m_unitMode); }
bool operator==(const SVGLength&) const;
@@ -72,8 +66,11 @@ public:
float value(const SVGLengthContext&) const;
void setValue(float, const SVGLengthContext&);
- float valueInSpecifiedUnits() const { return m_valueInSpecifiedUnits; }
- void setValueInSpecifiedUnits(float value) { m_valueInSpecifiedUnits = value; }
+ float valueInSpecifiedUnits() const { return m_value->getFloatValue(); }
+ void setValueInSpecifiedUnits(float value)
+ {
+ m_value = CSSPrimitiveValue::create(value, m_value->typeWithCalcResolved());
+ }
// Resolves LengthTypePercentage into a normalized floating point number (full value is 1.0).
float valueAsPercentage() const;
@@ -87,23 +84,23 @@ public:
String valueAsString() const override;
void setValueAsString(const String&, ExceptionState&);
- void newValueSpecifiedUnits(SVGLengthType, float valueInSpecifiedUnits);
- void convertToSpecifiedUnits(SVGLengthType, const SVGLengthContext&);
+ void newValueSpecifiedUnits(CSSPrimitiveValue::UnitType, float valueInSpecifiedUnits);
+ void convertToSpecifiedUnits(CSSPrimitiveValue::UnitType, const SVGLengthContext&);
// Helper functions
- static inline bool isRelativeUnit(SVGLengthType unitType)
+ static inline bool isRelativeUnit(CSSPrimitiveValue::UnitType unitType)
{
- return unitType == LengthTypePercentage
- || unitType == LengthTypeEMS
- || unitType == LengthTypeEXS
- || unitType == LengthTypeREMS
- || unitType == LengthTypeCHS;
+ return unitType == CSSPrimitiveValue::UnitType::Percentage
+ || unitType == CSSPrimitiveValue::UnitType::Ems
+ || unitType == CSSPrimitiveValue::UnitType::Exs
+ || unitType == CSSPrimitiveValue::UnitType::Rems
+ || unitType == CSSPrimitiveValue::UnitType::Chs;
}
- inline bool isRelative() const { return isRelativeUnit(unitType()); }
+ inline bool isRelative() const { return isRelativeUnit(m_value->typeWithCalcResolved()); }
bool isZero() const
{
- return !m_valueInSpecifiedUnits;
+ return m_value->getFloatValue() == 0;
}
static SVGLengthMode lengthModeForAnimatedLengthAttribute(const QualifiedName&);
@@ -118,9 +115,8 @@ private:
SVGLength(SVGLengthMode);
SVGLength(const SVGLength&);
- float m_valueInSpecifiedUnits;
+ RefPtrWillBeMember<CSSPrimitiveValue> m_value;
unsigned m_unitMode : 2;
- unsigned m_unitType : 4;
};
DEFINE_SVG_PROPERTY_TYPE_CASTS(SVGLength);
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp ('k') | third_party/WebKit/Source/core/svg/SVGLength.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698