Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGLength.js

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added expectation Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGLength.js
diff --git a/third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGLength.js b/third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGLength.js
index ba7663d12828bd6f62ef890bf10582828766aeb6..01d8279cd827a3920f0ba3409f0f0077cb5f6d5a 100644
--- a/third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGLength.js
+++ b/third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGLength.js
@@ -71,12 +71,14 @@ shouldBe("length.value", "2");
shouldBe("length.valueInSpecifiedUnits", "2");
shouldBe("length.unitType", "SVGLength.SVG_LENGTHTYPE_PX");
-shouldThrow("length.valueAsString = '1pX'");
-shouldBeEqualToString("length.valueAsString", "2px");
-shouldBe("length.value", "2");
-shouldBe("length.valueInSpecifiedUnits", "2");
+shouldNotThrow("length.valueAsString = '1pX'");
+shouldBeEqualToString("length.valueAsString", "1px");
+shouldBe("length.value", "1");
+shouldBe("length.valueInSpecifiedUnits", "1");
shouldBe("length.unitType", "SVGLength.SVG_LENGTHTYPE_PX");
+length.valueAsString = "2px"; // reset to 2px
+
shouldThrow("length.valueAsString = ',5 em'");
shouldBeEqualToString("length.valueAsString", "2px");
shouldBe("length.value", "2");

Powered by Google App Engine
This is Rietveld 408576698