third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments and tests addressed Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

index 3b0046797503e6ed25a99da55128fd4ba6545c6c..f84f25d4bb463be3fe46307d06d37eacb3d0e6fa 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -110,9 +110,13 @@ static PassRefPtrWillBeRawPtr<CSSValue> parseSimpleLengthValue(CSSPropertyID pro

if (unit == CSSPrimitiveValue::UnitType::Number) {

bool quirksMode = isQuirksModeBehavior(cssParserMode);

- if (number && !quirksMode)

+ bool svgMode = cssParserMode == SVGAttributeMode;

+ if (number && (!quirksMode && !svgMode))

return nullptr;

- unit = CSSPrimitiveValue::UnitType::Pixels;

+ if (svgMode)

+ unit = CSSPrimitiveValue::UnitType::UserUnits;

+ else

+ unit = CSSPrimitiveValue::UnitType::Pixels;

}

if (number < 0 && !acceptsNegativeNumbers)

return nullptr;