third_party/WebKit/Source/core/svg/SVGSVGElement.cpp - Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

index fce14cf46b7e1a0a43f5fcb5ced6709fae88b061..ef466e2f6b1f479297b556a036bde23603c6f1db 100644

--- a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

@@ -634,17 +634,17 @@ FloatSize SVGSVGElement::currentViewportSize() const

bool SVGSVGElement::hasIntrinsicWidth() const

{

- return width()->currentValue()->unitType() != LengthTypePercentage;

+ return width()->currentValue()->typeWithCalcResolved() != CSSPrimitiveValue::UnitType::Percentage;

}

bool SVGSVGElement::hasIntrinsicHeight() const

{

- return height()->currentValue()->unitType() != LengthTypePercentage;

+ return height()->currentValue()->typeWithCalcResolved() != CSSPrimitiveValue::UnitType::Percentage;

}

Length SVGSVGElement::intrinsicWidth() const

{

- if (width()->currentValue()->unitType() == LengthTypePercentage)

+ if (width()->currentValue()->typeWithCalcResolved() == CSSPrimitiveValue::UnitType::Percentage)

return Length(0, Fixed);

SVGLengthContext lengthContext(this);

@@ -653,7 +653,7 @@ Length SVGSVGElement::intrinsicWidth() const

Length SVGSVGElement::intrinsicHeight() const

{

- if (height()->currentValue()->unitType() == LengthTypePercentage)

+ if (height()->currentValue()->typeWithCalcResolved() == CSSPrimitiveValue::UnitType::Percentage)

return Length(0, Fixed);

SVGLengthContext lengthContext(this);