third_party/WebKit/Source/core/svg/SVGLengthTearOff.h - Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthTearOff.h

Issue 1421533006: Make SVGLength wrap a CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGLengthList.cpp ('k') | third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGLengthTearOff.h

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthTearOff.h b/third_party/WebKit/Source/core/svg/SVGLengthTearOff.h

index 8714f7b55585c9583b62679225030f03d9f37db7..81e5377abce76f806ebdd0aa8b8c2bc6867c4226 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthTearOff.h

+++ b/third_party/WebKit/Source/core/svg/SVGLengthTearOff.h

@@ -32,9 +32,11 @@

#define SVGLengthTearOff_h

#include "bindings/core/v8/ScriptWrappable.h"

+#include "core/css/CSSPrimitiveValue.h"

#include "core/svg/SVGLength.h"

#include "core/svg/properties/SVGPropertyTearOff.h"

fs 2015/10/23 20:28:59 Nit: Drop

namespace blink {

class SVGLengthTearOff final : public SVGPropertyTearOff<SVGLength>, public ScriptWrappable {

@@ -71,7 +73,7 @@ public:

void newValueSpecifiedUnits(unsigned short unitType, float valueInSpecifiedUnits, ExceptionState&);

void convertToSpecifiedUnits(unsigned short unitType, ExceptionState&);

- bool hasExposedLengthUnit() { return target()->unitType() <= LengthTypePC; }

+ bool hasExposedLengthUnit() { return target()->typeWithCalcResolved() <= CSSPrimitiveValue::UnitType::Picas; }

private:

SVGLengthTearOff(PassRefPtrWillBeRawPtr<SVGLength>, SVGElement* contextElement, PropertyIsAnimValType, const QualifiedName& attributeName = QualifiedName::null());