content/browser/frame_host/navigation_request.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_request.cc

diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc

index 171b1b5a510d3545be73887ad9d262fffa1a13b1..4fb2eb9a8f53c313ee80d2563fa0f95b27f8224c 100644

--- a/content/browser/frame_host/navigation_request.cc

+++ b/content/browser/frame_host/navigation_request.cc

@@ -158,7 +158,7 @@ NavigationRequest::NavigationRequest(

restore_type_(NavigationEntryImpl::RESTORE_NONE),

is_view_source_(false),

bindings_(NavigationEntryImpl::kInvalidBindings) {

- DCHECK_IMPLIES(browser_initiated, entry != nullptr && frame_entry != nullptr);

+ DCHECK(!browser_initiated || (entry != nullptr && frame_entry != nullptr));

if (browser_initiated) {

// TODO(clamy): use the FrameNavigationEntry for the source SiteInstance

// once it has been moved from the NavigationEntry.