ui/views/touchui/touch_selection_menu_runner_views.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/touchui/touch_selection_menu_runner_views.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/touchui/touch_selection_menu_runner_views.cc

diff --git a/ui/views/touchui/touch_selection_menu_runner_views.cc b/ui/views/touchui/touch_selection_menu_runner_views.cc

index 6f44e526957c84f4f8ac1b2e7d82f29eb5755926..55b532cc778df9acd95573062b2984034bcb7da5 100644

--- a/ui/views/touchui/touch_selection_menu_runner_views.cc

+++ b/ui/views/touchui/touch_selection_menu_runner_views.cc

@@ -195,7 +195,7 @@ void TouchSelectionMenuRunnerViews::Menu::OnPaint(gfx::Canvas* canvas) {

}

void TouchSelectionMenuRunnerViews::Menu::WindowClosing() {

- DCHECK_IMPLIES(owner_, owner_->menu_ == this);

+ DCHECK(!owner_ || owner_->menu_ == this);

BubbleDelegateView::WindowClosing();

if (owner_)

owner_->menu_ = nullptr;

« no previous file with comments | « ui/gl/gl_image_memory.cc ('k') | ui/views/view.cc » ('j') | no next file with comments »