content/renderer/gpu/mailbox_output_surface.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/mailbox_output_surface.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/gpu/mailbox_output_surface.cc

diff --git a/content/renderer/gpu/mailbox_output_surface.cc b/content/renderer/gpu/mailbox_output_surface.cc

index fe6bd6aeb41c9fdf3e4995903f5c9a25029bab6d..a536f9928d71dad9ee05ead3913d460d1c0a359b 100644

--- a/content/renderer/gpu/mailbox_output_surface.cc

+++ b/content/renderer/gpu/mailbox_output_surface.cc

@@ -200,9 +200,9 @@ void MailboxOutputSurface::SwapBuffers(cc::CompositorFrame* frame) {

DCHECK(!surface_size_.IsEmpty());

DCHECK(surface_size_ == current_backing_.size);

DCHECK(frame->gl_frame_data->size == current_backing_.size);

- DCHECK_IMPLIES(current_backing_.mailbox.IsZero(),

- context_provider_->ContextGL()->GetGraphicsResetStatusKHR() !=

- GL_NO_ERROR);

+ DCHECK(!current_backing_.mailbox.IsZero() ||

+ context_provider_->ContextGL()->GetGraphicsResetStatusKHR() !=

+ GL_NO_ERROR);

frame->gl_frame_data->mailbox = current_backing_.mailbox;

context_provider_->ContextGL()->Flush();