Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3586)

Unified Diff: cc/playback/display_item_list.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/resources/texture_mailbox.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/display_item_list.cc
diff --git a/cc/playback/display_item_list.cc b/cc/playback/display_item_list.cc
index fbf184aad7a06bf605879ea3478a2255811f31f2..6d0edc659819aa02caa59dbb70af72f57813686b 100644
--- a/cc/playback/display_item_list.cc
+++ b/cc/playback/display_item_list.cc
@@ -168,7 +168,7 @@ void DisplayItemList::ProcessAppendedItems() {
}
if (retain_individual_display_items_) {
- // Warning: this double-counts SkPicture data if use_cached_picture_ is
+ // Warning: this double-counts SkPicture data if use_cached_picture is
// also true.
external_memory_usage_ += item->external_memory_usage();
}
@@ -233,7 +233,7 @@ size_t DisplayItemList::ApproximateMemoryUsage() const {
if (settings_.use_cached_picture && retain_individual_display_items_)
return 0;
- DCHECK_IMPLIES(settings_.use_cached_picture, picture_);
+ DCHECK(!settings_.use_cached_picture || picture_);
size_t memory_usage = sizeof(*this);
@@ -303,7 +303,7 @@ void DisplayItemList::GenerateDiscardableImagesMetadata() {
DCHECK(ProcessAppendedItemsCalled());
// This should be only called once, and only after CreateAndCacheSkPicture.
DCHECK(image_map_.empty());
- DCHECK_IMPLIES(settings_.use_cached_picture, picture_);
+ DCHECK(!settings_.use_cached_picture || picture_);
if (settings_.use_cached_picture && !picture_->willPlayBackBitmaps())
return;
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/resources/texture_mailbox.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698