Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: cc/resources/texture_mailbox.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/playback/display_item_list.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/texture_mailbox.h" 5 #include "cc/resources/texture_mailbox.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "cc/resources/shared_bitmap.h" 8 #include "cc/resources/shared_bitmap.h"
9 9
10 namespace cc { 10 namespace cc {
(...skipping 18 matching lines...) Expand all
29 TextureMailbox::TextureMailbox(const gpu::Mailbox& mailbox, 29 TextureMailbox::TextureMailbox(const gpu::Mailbox& mailbox,
30 uint32 target, 30 uint32 target,
31 uint32 sync_point, 31 uint32 sync_point,
32 const gfx::Size& size_in_pixels, 32 const gfx::Size& size_in_pixels,
33 bool is_overlay_candidate) 33 bool is_overlay_candidate)
34 : mailbox_holder_(mailbox, target, sync_point), 34 : mailbox_holder_(mailbox, target, sync_point),
35 shared_bitmap_(nullptr), 35 shared_bitmap_(nullptr),
36 size_in_pixels_(size_in_pixels), 36 size_in_pixels_(size_in_pixels),
37 is_overlay_candidate_(is_overlay_candidate), 37 is_overlay_candidate_(is_overlay_candidate),
38 nearest_neighbor_(false) { 38 nearest_neighbor_(false) {
39 DCHECK_IMPLIES(is_overlay_candidate, !size_in_pixels.IsEmpty()); 39 DCHECK(!is_overlay_candidate || !size_in_pixels.IsEmpty());
40 } 40 }
41 41
42 TextureMailbox::TextureMailbox(SharedBitmap* shared_bitmap, 42 TextureMailbox::TextureMailbox(SharedBitmap* shared_bitmap,
43 const gfx::Size& size_in_pixels) 43 const gfx::Size& size_in_pixels)
44 : shared_bitmap_(shared_bitmap), 44 : shared_bitmap_(shared_bitmap),
45 size_in_pixels_(size_in_pixels), 45 size_in_pixels_(size_in_pixels),
46 is_overlay_candidate_(false), 46 is_overlay_candidate_(false),
47 nearest_neighbor_(false) { 47 nearest_neighbor_(false) {
48 // If an embedder of cc gives an invalid TextureMailbox, we should crash 48 // If an embedder of cc gives an invalid TextureMailbox, we should crash
49 // here to identify the offender. 49 // here to identify the offender.
(...skipping 15 matching lines...) Expand all
65 return !IsValid(); 65 return !IsValid();
66 } 66 }
67 67
68 size_t TextureMailbox::SharedMemorySizeInBytes() const { 68 size_t TextureMailbox::SharedMemorySizeInBytes() const {
69 // UncheckedSizeInBytes is okay because we VerifySizeInBytes in the 69 // UncheckedSizeInBytes is okay because we VerifySizeInBytes in the
70 // constructor and the field is immutable. 70 // constructor and the field is immutable.
71 return SharedBitmap::UncheckedSizeInBytes(size_in_pixels_); 71 return SharedBitmap::UncheckedSizeInBytes(size_in_pixels_);
72 } 72 }
73 73
74 } // namespace cc 74 } // namespace cc
OLDNEW
« no previous file with comments | « cc/playback/display_item_list.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698