Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421483003: mandoline: Start adding trace events for mandoline stuff. (Closed)

Created:
5 years, 2 months ago by Elliot Glaysher
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: Start adding trace events for mandoline stuff. BUG=534895 Committed: https://crrev.com/127dbee2bb1cda047f9314646e889f6a001fd9b5 Cr-Commit-Position: refs/heads/master@{#355915}

Patch Set 1 #

Patch Set 2 : Save buffer #

Patch Set 3 : Merge with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M components/font_service/public/cpp/font_loader.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M components/html_viewer/html_document.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M components/html_viewer/html_frame.cc View 4 chunks +7 lines, -0 lines 0 comments Download
M components/web_view/find_controller.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M components/web_view/frame.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M sql/mojo/mojo_vfs.cc View 1 10 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Elliot Glaysher
This doesn't depend on https://codereview.chromium.org/1409223004/ landing, but it isn't useful without it.
5 years, 2 months ago (2015-10-23 18:21:43 UTC) #2
Elliot Glaysher
+shess for sql stamp
5 years, 2 months ago (2015-10-23 20:15:44 UTC) #5
Scott Hess - ex-Googler
lgtm
5 years, 2 months ago (2015-10-23 20:40:34 UTC) #6
sky
LGTM
5 years, 2 months ago (2015-10-23 22:04:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421483003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421483003/40001
5 years, 2 months ago (2015-10-23 22:56:32 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-23 23:04:54 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 23:05:39 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/127dbee2bb1cda047f9314646e889f6a001fd9b5
Cr-Commit-Position: refs/heads/master@{#355915}

Powered by Google App Engine
This is Rietveld 408576698