Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1421473008: Rebaseline fast/text/atsui-rtl-override-selection.html for Mac10.6 (Closed)

Created:
5 years, 1 month ago by kojii
Modified:
5 years, 1 month ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline fast/text/atsui-rtl-override-selection.html for Mac10.6 fast/text/atsui-rtl-override-selection.html had incorrect offset on Mac OS X 10.6 (Snow Loepard) and the CL to fix selectionRect[1] fixed it. This patch adds NeedsRebaseline because the expected file has the incorrect image. [1] https://codereview.chromium.org/1420043007 BUG=550336 Committed: https://crrev.com/aa5db17a18950a2484e6d90663fad4cd8d1b1cb5 Cr-Commit-Position: refs/heads/master@{#357353}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kojii
PTAL.
5 years, 1 month ago (2015-11-02 13:00:33 UTC) #3
hiroshige
lgtm.
5 years, 1 month ago (2015-11-02 14:43:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421473008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421473008/20001
5 years, 1 month ago (2015-11-02 14:43:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-02 14:48:39 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 14:49:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa5db17a18950a2484e6d90663fad4cd8d1b1cb5
Cr-Commit-Position: refs/heads/master@{#357353}

Powered by Google App Engine
This is Rietveld 408576698