Chromium Code Reviews| Index: snapshot/win/process_snapshot_win.cc |
| diff --git a/snapshot/win/process_snapshot_win.cc b/snapshot/win/process_snapshot_win.cc |
| index ca26d4b82134c1d99e89efe9a6c7e86aa2806974..e5ee48a8d7397896f886eee4d4b1e051dfff4cd1 100644 |
| --- a/snapshot/win/process_snapshot_win.cc |
| +++ b/snapshot/win/process_snapshot_win.cc |
| @@ -18,6 +18,7 @@ |
| #include "base/logging.h" |
| #include "base/strings/stringprintf.h" |
| +#include "base/strings/utf_string_conversions.h" |
| #include "snapshot/win/memory_snapshot_win.h" |
| #include "snapshot/win/module_snapshot_win.h" |
| #include "util/win/registration_protocol_win.h" |
| @@ -211,7 +212,10 @@ std::vector<HandleSnapshot> ProcessSnapshotWin::Handles() const { |
| std::vector<HandleSnapshot> result; |
| for (const auto& handle : process_reader_.GetProcessInfo().Handles()) { |
| HandleSnapshot snapshot; |
| - snapshot.type_name = handle.type_name; |
| + // This is probably not strictly correct, but these are not localized so we |
| + // expect them all to be in ASCII range anyway. This will need to be more |
| + // carefully done if the object name is added. |
|
Mark Mentovai
2015/10/21 18:31:28
As long as the only consumer is the minidump write
|
| + snapshot.type_name = base::UTF16ToUTF8(handle.type_name); |
| snapshot.handle = handle.handle; |
| snapshot.attributes = handle.attributes; |
| snapshot.granted_access = handle.granted_access; |