Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1421463009: Reland of Fix formatting specifier for MSVC++ 2013 compatibility. (Closed)

Created:
5 years, 1 month ago by miu
Modified:
5 years, 1 month ago
Reviewers:
tommycli, brucedawson
CC:
chromium-reviews, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix formatting specifier for MSVC++ 2013 compatibility. (patchset #1 id:1 of https://codereview.chromium.org/1414883010/ ) Reason for revert: Per off-line conversation, this wasn't the cause of the memory bot failures. Back into the tree you go! :) Original issue's description: > Revert of Fix formatting specifier for MSVC++ 2013 compatibility. (patchset #1 id:1 of https://codereview.chromium.org/1411663012/ ) > > Reason for revert: > Speculatively revert to try to fix this: > > http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20(DrMemory%20full)%20(2) > > The error message is very obtuse, but seems to indicate it's some kind of string formatting issue. Feel free to revert the revert if it doesn't fix the issue. > > Tommy > > Original issue's description: > > Fix formatting specifier for MSVC++ 2013 compatibility. > > > > The use of %zu in a printf format string is non-standard. This change > > is a follow-up to https://codereview.chromium.org/1417873007 to use the > > standard PRIuS macro instead. > > > > BUG=519022 > > TBR=brucedawson@chromium.org > > > > Committed: https://crrev.com/1dbefc62bf1df69475bea39c5a41f7825c72a6b0 > > Cr-Commit-Position: refs/heads/master@{#357582} > > TBR=brucedawson@chromium.org,miu@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=519022 > > Committed: https://crrev.com/2054dbed4e6ade0129716eeffdcd9f2e4b34fd1c > Cr-Commit-Position: refs/heads/master@{#357956} TBR=brucedawson@chromium.org,tommycli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=519022 Committed: https://crrev.com/4f39e75faf07800d60c76616716040f35cefd868 Cr-Commit-Position: refs/heads/master@{#358125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/cast/sender/external_video_encoder.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
miu
Created Reland of Fix formatting specifier for MSVC++ 2013 compatibility.
5 years, 1 month ago (2015-11-05 20:52:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421463009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421463009/1
5 years, 1 month ago (2015-11-05 20:53:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 20:55:10 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 20:56:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f39e75faf07800d60c76616716040f35cefd868
Cr-Commit-Position: refs/heads/master@{#358125}

Powered by Google App Engine
This is Rietveld 408576698