Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1421463005: Move codegen registration to transformImpact method. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/compiler.dart ('K') | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/js_backend.dart » ('j') | pkg/compiler/lib/src/resolution/registry.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index d27c1f05567610c3023cbbe959ef2d57d305b682..28b9e0548130cf70206b5794613ec41c6ab67b01 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -838,7 +838,9 @@ class CodeGenerator extends tree_ir.StatementVisitor
}
js.Node handleForeignCode(tree_ir.ForeignCode node) {
- registry.registerStaticUse(node.dependency);
+ if (node.dependency != null) {
sigurdm 2015/10/26 15:04:10 Add comment - why can node.dependency be null?
Johnni Winther 2015/10/27 10:33:51 Done.
+ registry.registerStaticUse(node.dependency);
+ }
// TODO(sra): Should this be in CodegenRegistry?
glue.registerNativeBehavior(node.nativeBehavior, node);
return node.codeTemplate.instantiate(visitExpressionList(node.arguments));
« pkg/compiler/lib/src/compiler.dart ('K') | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/js_backend.dart » ('j') | pkg/compiler/lib/src/resolution/registry.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698