Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1421463005: Move codegen registration to transformImpact method. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move codegen registration to transformImpact method. This prepares for only registering through WorldImpact. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/529bc75d81da1dbb65a9c1149aaaa05c9a415c37

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -274 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 5 chunks +22 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 2 chunks +209 lines, -43 lines 0 comments Download
M pkg/compiler/lib/src/common/registry.dart View 2 chunks +48 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 3 chunks +0 lines, -130 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 3 chunks +11 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 4 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 10 chunks +107 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 5 chunks +5 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +0 lines, -45 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/common/registry.dart File pkg/compiler/lib/src/common/registry.dart (right): https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/common/registry.dart#newcode36 pkg/compiler/lib/src/common/registry.dart:36: Moved here from resolution/registry.dart https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/common/resolution.dart File pkg/compiler/lib/src/common/resolution.dart (left): https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/common/resolution.dart#oldcode185 ...
5 years, 1 month ago (2015-10-26 14:12:37 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/compiler.dart#newcode2054 pkg/compiler/lib/src/compiler.dart:2054: Enqueuer get world => compiler.enqueuer.codegen; is "world" the ...
5 years, 1 month ago (2015-10-26 15:04:10 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 529bc75d81da1dbb65a9c1149aaaa05c9a415c37 (presubmit successful).
5 years, 1 month ago (2015-10-27 09:10:09 UTC) #4
Johnni Winther
5 years, 1 month ago (2015-10-27 10:33:52 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:2054: Enqueuer get world =>
compiler.enqueuer.codegen;
On 2015/10/26 15:04:10, sigurdm wrote:
> is "world" the best word for this? What about "codegenEnqueuer"?

No. It's an override. We need refactor in general (seeing a CL in the horizon)

https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/1421463005/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:841: if (node.dependency !=
null) {
On 2015/10/26 15:04:10, sigurdm wrote:
> Add comment - why can node.dependency be null?

Done.

Powered by Google App Engine
This is Rietveld 408576698