Add a mutex to protect the DWrite calls.

Add a mutex to protect the DWrite calls.

BUG=skia:4479
Committed: https://skia.googlesource.com/skia/+/c7378af961cabef5b77c4dae40d8d3b9c1471a9e

[herb_g, 2015-10-20 21:50:27]

Description was changed from

==========
Add a mutex to protect the DWrite calls.

BUG=skia:
==========

to

==========
Add a mutex to protect the DWrite calls.

BUG=skia:
==========

[herb_g, 2015-10-20 21:50:27]

herb@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2015-10-20 21:56:24]

The tabs and 8 space indents and over 100 character long comments. I'm not sure
why some blocks seem to change to tabs but don't otherwise seem changed.

Tools > Options > Text Editor > C/C++ > Tabs

[herb_g, 2015-10-21 14:29:53]

All fixed. PTAL

[bungeman-skia, 2015-10-21 14:44:31]

https://codereview.chromium.org/1421433004/diff/40001/src/ports/SkScalerConte...
File src/ports/SkScalerContext_win_dw.cpp (right):

https://codereview.chromium.org/1421433004/diff/40001/src/ports/SkScalerConte...
src/ports/SkScalerContext_win_dw.cpp:40: class Exclusive {
What is this providing us that SkAutoMutexAcquire isn't already? Is the idea to
make this more like FCLocker in src/ports/SkFontMgr_fontconfig.cpp?

https://codereview.chromium.org/1421433004/diff/40001/src/ports/SkScalerConte...
src/ports/SkScalerContext_win_dw.cpp:503: 
Stray extra line?

[herb_g, 2015-10-21 14:49:49]

Description was changed from

==========
Add a mutex to protect the DWrite calls.

BUG=skia:
==========

to

==========
Add a mutex to protect the DWrite calls.

BUG=skia:4479
==========

[herb_g, 2015-10-21 14:54:41]

https://codereview.chromium.org/1421433004/diff/40001/src/ports/SkScalerConte...
File src/ports/SkScalerContext_win_dw.cpp (right):

https://codereview.chromium.org/1421433004/diff/40001/src/ports/SkScalerConte...
src/ports/SkScalerContext_win_dw.cpp:40: class Exclusive {
On 2015/10/21 14:44:31, bungeman1 wrote:
> What is this providing us that SkAutoMutexAcquire isn't already? Is the idea
to
> make this more like FCLocker in src/ports/SkFontMgr_fontconfig.cpp?

SkAutoMutexAcquire is heavier weight because it always check to see if the mutex
is NULL (this is used in some use cases in the code). Since the mutex can not be
NULL, then this wrapper can be lighter weight and results in fewer if
statements. This pattern has been used in other parts of the code.

https://codereview.chromium.org/1421433004/diff/40001/src/ports/SkScalerConte...
src/ports/SkScalerContext_win_dw.cpp:503: 
On 2015/10/21 14:44:31, bungeman1 wrote:
> Stray extra line?

Done.

[herb_g, 2015-10-21 15:00:48]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-21 15:00:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421433004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421433004/60001

[commit-bot: I haz the power, 2015-10-21 15:10:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 15:10:19]

Dry run: This issue passed the CQ dry run.

[caryclark, 2015-10-21 15:15:22]

caryclark@google.com changed reviewers:
+ caryclark@google.com

[caryclark, 2015-10-21 15:15:22]

lgtm

[bungeman-skia, 2015-10-21 15:27:13]

https://codereview.chromium.org/1421433004/diff/40001/src/ports/SkScalerConte...
File src/ports/SkScalerContext_win_dw.cpp (right):

https://codereview.chromium.org/1421433004/diff/40001/src/ports/SkScalerConte...
src/ports/SkScalerContext_win_dw.cpp:40: class Exclusive {
On 2015/10/21 14:54:41, herb_g wrote:
> On 2015/10/21 14:44:31, bungeman1 wrote:
> > What is this providing us that SkAutoMutexAcquire isn't already? Is the idea
> to
> > make this more like FCLocker in src/ports/SkFontMgr_fontconfig.cpp?
> 
> SkAutoMutexAcquire is heavier weight because it always check to see if the
mutex
> is NULL (this is used in some use cases in the code). Since the mutex can not
be
> NULL, then this wrapper can be lighter weight and results in fewer if
> statements. This pattern has been used in other parts of the code.

The extra check against NULL is pretty much nothing against the rest of the
mutex. In addition, if this is being done in other parts of the code it needs to
be factored out instead of adding yet another name for this.

[bungeman-skia, 2015-10-21 15:40:28]

lgtm

[herb_g, 2015-10-21 16:23:57]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2015-10-21 16:24:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421433004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421433004/60001

[commit-bot: I haz the power, 2015-10-21 16:24:40]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c7378af961cabef5b77c4dae40d8d3b9c1471a9e