Convert the SkiaBenchmarkingExtension to a gin::Wrappable class

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 98 matching lines @@
 #include "content/renderer/render_frame_impl.h"
 #include "content/renderer/render_process.h"
 #include "content/renderer/render_thread_impl.h"
 #include "content/renderer/render_view_impl_params.h"
 #include "content/renderer/render_view_mouse_lock_dispatcher.h"
 #include "content/renderer/render_widget_fullscreen_pepper.h"
 #include "content/renderer/renderer_webapplicationcachehost_impl.h"
 #include "content/renderer/renderer_webcolorchooser_impl.h"
 #include "content/renderer/resizing_mode_selector.h"
 #include "content/renderer/savable_resources.h"
+#include "content/renderer/skia_benchmarking_extension.h"
 #include "content/renderer/speech_recognition_dispatcher.h"
 #include "content/renderer/stats_collection_controller.h"
 #include "content/renderer/stats_collection_observer.h"
 #include "content/renderer/text_input_client_observer.h"
 #include "content/renderer/v8_value_converter_impl.h"
 #include "content/renderer/web_ui_extension.h"
 #include "content/renderer/web_ui_extension_data.h"
 #include "content/renderer/websharedworker_proxy.h"
 #include "media/audio/audio_output_device.h"
 #include "media/base/audio_renderer_mixer_input.h"
@@ skipping 3506 matching lines @@
           RenderViewNavigatedToHost(GURL(GetLoadingUrl(frame)).host(),
                                     g_view_map.Get().size());
     }
   }
 }
 
 void RenderViewImpl::didClearWindowObject(WebFrame* frame, int world_id) {
   FOR_EACH_OBSERVER(RenderViewObserver, observers_,
                     DidClearWindowObject(frame, world_id));
 
-  if ((enabled_bindings_ & BINDINGS_POLICY_DOM_AUTOMATION) && (world_id == 0))
-    DomAutomationController::Install(this, frame);
+  if (world_id == 0) {
+    if ((enabled_bindings_ & BINDINGS_POLICY_DOM_AUTOMATION))
+      DomAutomationController::Install(this, frame);
 
-  if (enabled_bindings_ & BINDINGS_POLICY_STATS_COLLECTION)
-    StatsCollectionController::Install(frame);
+    if (enabled_bindings_ & BINDINGS_POLICY_STATS_COLLECTION)
+      StatsCollectionController::Install(frame);

[piman, 2014/01/21 20:59:31]

I'm not sure what this does. Did you mean to include it the if (world_id == 0)?
It sounds like a change that's unrelated to the skia benchmarking.

[jochen (gone - plz use gerrit), 2014/01/22 12:17:05]

yes, I forgot about moving the stats controller under the if in my previous
change here.

+
+    const CommandLine& command_line = *CommandLine::ForCurrentProcess();
+
+    if (command_line.HasSwitch(switches::kEnableSkiaBenchmarking))
+      SkiaBenchmarking::Install(frame);
+  }
 }
 
 void RenderViewImpl::didCreateDocumentElement(WebFrame* frame) {
   FOR_EACH_OBSERVER(RenderViewObserver, observers_,
                     DidCreateDocumentElement(frame));
 }
 
 void RenderViewImpl::didReceiveTitle(WebFrame* frame, const WebString& title,
                                      WebTextDirection direction) {
   UpdateTitle(frame, title, direction);
@@ skipping 2573 matching lines @@
   for (size_t i = 0; i < icon_urls.size(); i++) {
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content