third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 1421423003: Require spanners to have the multicol container as their nearest block formatting context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1421423003: Require spanners to have the multicol container as their nearest block formatting context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test for bug 529737 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/span/spanner-in-flexbox-in-multicol-in-flexbox-crash-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index eb344ca69620b1060b448059b055069ed14e2685..b7c5cf8ea9bfbfcceecb8b39974603c141c97bba 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -132,6 +132,8 @@ public:

LayoutUnit minLineHeightForReplacedObject(bool isFirstLine, LayoutUnit replacedHeight) const;

+ bool createsNewFormattingContext() const;

const LineBoxList& lineBoxes() const { return m_lineBoxes; }

LineBoxList* lineBoxes() { return &m_lineBoxes; }

@@ -448,8 +450,6 @@ protected:

// is 800. AssociateWithFormerPage will simply return 800.

LayoutUnit nextPageLogicalTop(LayoutUnit logicalOffset, PageBoundaryRule) const;

- bool createsNewFormattingContext() const;

// Paginated content inside this block was laid out.

// |logicalTopOffsetAfterPagination| is the logical top offset of the child content after

// applying any forced or unforced break, if needed.