Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/span/spanner-in-flexbox-in-multicol-in-flexbox-crash.html

Issue 1421423003: Require spanners to have the multicol container as their nearest block formatting context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test for bug 529737 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/multicol/span/spanner-in-flexbox-in-multicol-in-flexbox-crash.html
diff --git a/third_party/WebKit/LayoutTests/fast/multicol/span/spanner-in-flexbox-in-multicol-in-flexbox-crash.html b/third_party/WebKit/LayoutTests/fast/multicol/span/spanner-in-flexbox-in-multicol-in-flexbox-crash.html
new file mode 100644
index 0000000000000000000000000000000000000000..58a173688bf56707f4c366c6a57011f615f0bd70
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/multicol/span/spanner-in-flexbox-in-multicol-in-flexbox-crash.html
@@ -0,0 +1,27 @@
+<!DOCTYPE html>
+<script src="../../../resources/check-layout.js"></script>
+<p>There should be a navajowhite square below, and a horizontal scrollbar. No red should be seen.</p>
+<div id="outerFlex" style="display:flex;">
+ <div>
+ <div style="-webkit-columns:3; -webkit-column-gap:10px; width:320px;">
+ <div style="display:flex; height:150px;">
+ <!-- Scrollable flex item. Its height will be stretched or (in this case) shrunk to
+ fill the containing flex container. -->
+ <div style="overflow-x:auto; overflow-y:hidden; flex:1;">
+ <!-- Invalid column spanner, since the nearest block formatting context isn't
+ the one established by the multicol container. -->
+ <div data-expected-width="100" style="-webkit-column-span:all; height:100px; background:navajowhite;"></div>
+
+ <!-- Add something that causes a scrollbar. Leave 50px blank for the scrollbar. -->
+ <div style="width:200%; margin-top:50px; height:150px; background:red;"></div>
+ </div>
+ </div>
+ <!-- We want the previous flexbox to live in only one column, so add some spacing to
+ make the multicol container tall enough for that. -->
+ <div style="height:300px;"></div>
+ </div>
+ </div>
+</div>
+<script>
+ checkLayout("#outerFlex");
+</script>

Powered by Google App Engine
This is Rietveld 408576698