Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1421413002: Update to ES2015 == semantics for Symbol/SIMD wrappers (Closed)

Created:
5 years, 1 month ago by Dan Ehrenberg
Modified:
5 years, 1 month ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update to ES2015 == semantics for Symbol/SIMD wrappers When == is invoked on a Symbol or SIMD vector and an object, the object should be converted to a primitive with ToPrimitive and then compared again. This means, for example, that for a Symbol or SIMD vector s, s == Object(s). This patch makes that change in the implementation of ==. Only the runtime function needed to be changed, as the code stubs and compiler specializations don't operate on Symbols or SIMD vectors, and on these types, a fallback to the runtime function is always used. BUG=v8:3593 LOG=Y R=adamk Committed: https://crrev.com/b436635ac4f81f0248eefea4bc83e7cb0f5c3e21 Cr-Commit-Position: refs/heads/master@{#31614}

Patch Set 1 #

Patch Set 2 : fix formatting #

Patch Set 3 : Fix tests #

Patch Set 4 : Fixes a test262 test #

Patch Set 5 : make ordering closer to other clauses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -22 lines) Patch
M src/objects.cc View 1 2 3 4 4 chunks +37 lines, -12 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/double-equals.js View 2 chunks +14 lines, -0 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/private.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/simd.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421413002/1
5 years, 1 month ago (2015-10-27 04:17:14 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7100)
5 years, 1 month ago (2015-10-27 04:19:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421413002/20001
5 years, 1 month ago (2015-10-27 05:22:36 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/5790)
5 years, 1 month ago (2015-10-27 05:31:56 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421413002/40001
5 years, 1 month ago (2015-10-27 16:47:54 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/11178)
5 years, 1 month ago (2015-10-27 17:01:46 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421413002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421413002/60001
5 years, 1 month ago (2015-10-27 17:02:24 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-27 17:31:31 UTC) #16
Dan Ehrenberg
PTAL; I think this patch should be sufficient (see commit message for explanation).
5 years, 1 month ago (2015-10-27 18:19:38 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421413002/80001
5 years, 1 month ago (2015-10-27 18:47:50 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-27 19:05:35 UTC) #22
Dan Ehrenberg
Fixed the ordering to be cleaner. PTAL
5 years, 1 month ago (2015-10-27 19:42:50 UTC) #23
adamk
lgtm
5 years, 1 month ago (2015-10-27 20:13:51 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421413002/80001
5 years, 1 month ago (2015-10-27 20:18:52 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-10-27 20:20:13 UTC) #27
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 20:20:35 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b436635ac4f81f0248eefea4bc83e7cb0f5c3e21
Cr-Commit-Position: refs/heads/master@{#31614}

Powered by Google App Engine
This is Rietveld 408576698