Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1421293009: Update comments about ISO spec on aac parser. (Closed)

Created:
5 years, 1 month ago by msu.koo
Modified:
5 years, 1 month ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comments about ISO spec on aac parser. Previously comments on aac_parser did not specify which edition of ISO 14496-3 it refered. This patch is to update the comments to clearly specify that current implementation refers ISO 14496-3:2005. BUG=532281 Committed: https://crrev.com/5a2ae99953738eaefe9ddb813289e0eafc598200 Cr-Commit-Position: refs/heads/master@{#359027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M media/formats/mp4/aac.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M media/formats/mp4/aac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
msu.koo
Hello, wolenetz :) I updated some comments on aac parser. Could you take a look ...
5 years, 1 month ago (2015-11-10 04:19:10 UTC) #2
wolenetz
lgtm
5 years, 1 month ago (2015-11-10 23:54:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421293009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421293009/1
5 years, 1 month ago (2015-11-11 01:47:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 02:49:56 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 02:50:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a2ae99953738eaefe9ddb813289e0eafc598200
Cr-Commit-Position: refs/heads/master@{#359027}

Powered by Google App Engine
This is Rietveld 408576698