Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: tools/gn/exec_process.cc

Issue 1421293008: include what you use: errno.h in exec_process.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/exec_process.cc
diff --git a/tools/gn/exec_process.cc b/tools/gn/exec_process.cc
index e15f595d1541c5a424e975e72ac89880279eb032..612399149e57d8a20aa7dd0fd8f1e63df5f1d195 100644
--- a/tools/gn/exec_process.cc
+++ b/tools/gn/exec_process.cc
@@ -14,6 +14,8 @@
#include "base/win/scoped_handle.h"
#include "base/win/scoped_process_information.h"
+#else
+#include <errno.h>
tfarina 2015/11/07 16:10:56 Maybe do this in the POSIX case below?
Mostyn Bramley-Moore 2015/11/07 19:52:39 In this file errno is only used inside the else bl
tfarina 2015/11/08 13:59:33 Then should we move the includes below in this els
Mostyn Bramley-Moore 2015/11/09 16:40:07 I will defer to Brett on this.
brettw 2015/11/10 21:48:19 Personally I'd merge them all into the else.
Mostyn Bramley-Moore 2015/11/10 22:24:22 Done.
#endif
#if defined(OS_POSIX)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698