Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: tools/gn/exec_process.cc

Issue 1421293008: include what you use: errno.h in exec_process.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge posix includes into else case Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
tfarina 2015/11/10 22:28:36 just noticed this: exec_process.cc isn't including
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/files/file_util.h" 6 #include "base/files/file_util.h"
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/process/kill.h" 8 #include "base/process/kill.h"
9 #include "base/process/launch.h" 9 #include "base/process/launch.h"
10 #include "base/process/process.h" 10 #include "base/process/process.h"
11 11
12 #if defined(OS_WIN) 12 #if defined(OS_WIN)
13 #include <windows.h> 13 #include <windows.h>
14 14
15 #include "base/win/scoped_handle.h" 15 #include "base/win/scoped_handle.h"
16 #include "base/win/scoped_process_information.h" 16 #include "base/win/scoped_process_information.h"
17 #endif 17 #else
18 18 #include <errno.h>
19 #if defined(OS_POSIX)
20 #include <fcntl.h> 19 #include <fcntl.h>
21 #include <unistd.h> 20 #include <unistd.h>
22 21
23 #include "base/posix/eintr_wrapper.h" 22 #include "base/posix/eintr_wrapper.h"
24 #include "base/posix/file_descriptor_shuffle.h" 23 #include "base/posix/file_descriptor_shuffle.h"
25 #endif 24 #endif
26 25
27 namespace internal { 26 namespace internal {
28 27
29 #if defined(OS_WIN) 28 #if defined(OS_WIN)
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 return process.WaitForExit(exit_code); 244 return process.WaitForExit(exit_code);
246 } 245 }
247 } 246 }
248 247
249 return false; 248 return false;
250 } 249 }
251 #endif 250 #endif
252 251
253 } // namespace internal 252 } // namespace internal
254 253
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698