Use the iOS ABI when running SIMARM on Mac or targeting iOS.

Use the iOS ABI when running SIMARM on Mac or targeting iOS.

     Linux / iOS
R7   preserved / FP
R9   preserved / volatile
R11  FP / preserved

BUG=http://dartbug.com/24683
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/d422888b467eca0859d6110998a6671d3b473de0

[rmacnak, 2015-10-26 21:47:18]

Description was changed from

==========
Use the iOS ABI when running SIMARM on Mac.
==========

to

==========
Use the iOS ABI when running SIMARM on Mac.

BUG=http://dartbug.com/24683
==========

[rmacnak, 2015-10-27 20:15:25]

Description was changed from

==========
Use the iOS ABI when running SIMARM on Mac.

BUG=http://dartbug.com/24683
==========

to

==========
Use the iOS ABI when running SIMARM on Mac or targeting iOS.

BUG=http://dartbug.com/24683
==========

[rmacnak, 2015-10-27 20:17:06]

Description was changed from

==========
Use the iOS ABI when running SIMARM on Mac or targeting iOS.

     Linux / iOS
R7   preserved / FP
R9   preserved / volatile
R11  FP / preserved

BUG=http://dartbug.com/24683
==========

to

==========
Use the iOS ABI when running SIMARM on Mac or targeting iOS.

     Linux / iOS
R7   preserved / FP
R9   preserved / volatile
R11  FP / preserved

BUG=http://dartbug.com/24683
==========

[rmacnak, 2015-10-27 20:27:16]

rmacnak@google.com changed reviewers:
+ zra@google.com

[zra, 2015-10-27 20:46:41]

https://codereview.chromium.org/1421253004/diff/60001/runtime/vm/constants_arm.h
File runtime/vm/constants_arm.h (right):

https://codereview.chromium.org/1421253004/diff/60001/runtime/vm/constants_ar...
runtime/vm/constants_arm.h:51: R711 = R11,
NOTFP, or some other non-numeric name, might be a better defense against the
addition of yet another ABI with a different FP

https://codereview.chromium.org/1421253004/diff/60001/runtime/vm/simulator_ar...
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/1421253004/diff/60001/runtime/vm/simulator_ar...
runtime/vm/simulator_arm.cc:3731: // The code below assumes that r9 is not used
as sb (static base) in
Does this comment need to be updated?

[rmacnak, 2015-10-27 21:30:46]

https://codereview.chromium.org/1421253004/diff/60001/runtime/vm/constants_arm.h
File runtime/vm/constants_arm.h (right):

https://codereview.chromium.org/1421253004/diff/60001/runtime/vm/constants_ar...
runtime/vm/constants_arm.h:51: R711 = R11,
On 2015/10/27 20:46:41, zra wrote:
> NOTFP, or some other non-numeric name, might be a better defense against the
> addition of yet another ABI with a different FP

Yeah, they're both clunky but at least NOTFP wouldn't have to change again.

https://codereview.chromium.org/1421253004/diff/60001/runtime/vm/simulator_ar...
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/1421253004/diff/60001/runtime/vm/simulator_ar...
runtime/vm/simulator_arm.cc:3731: // The code below assumes that r9 is not used
as sb (static base) in
On 2015/10/27 20:46:41, zra wrote:
> Does this comment need to be updated?

I think this is still true and if r9 is a static base we shouldn't touch r9 at
all.

[zra, 2015-10-27 21:33:30]

lgtm

[rmacnak, 2015-10-27 21:36:42]

Committed patchset #5 (id:80001) manually as
d422888b467eca0859d6110998a6671d3b473de0 (presubmit successful).