Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1421173002: win: Disable C4201 in util.gyp for building without crashpad common.gypi (Closed)

Created:
5 years, 2 months ago by scottmg
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Disable C4201 in util.gyp for building without crashpad common.gypi R=mark@chromium.org BUG=crashpad:1, crashpad:526488 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1a9c8b0e9d8869704b43d212db3a8eda4b1ac8e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M util/util.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
5 years, 2 months ago (2015-10-23 20:55:58 UTC) #1
Mark Mentovai
LGTM. Do these leak beyond util?
5 years, 2 months ago (2015-10-23 20:59:24 UTC) #2
scottmg
On 2015/10/23 20:59:24, Mark Mentovai wrote: > LGTM. Do these leak beyond util? Not that ...
5 years, 2 months ago (2015-10-23 21:07:24 UTC) #3
scottmg
Committed patchset #1 (id:1) manually as 1a9c8b0e9d8869704b43d212db3a8eda4b1ac8e6 (presubmit successful).
5 years, 2 months ago (2015-10-23 21:08:06 UTC) #4
Mark Mentovai
Which structs/unions did you hit it for?
5 years, 2 months ago (2015-10-23 21:11:33 UTC) #5
scottmg
On 2015/10/23 21:11:33, Mark Mentovai wrote: > Which structs/unions did you hit it for? https://gist.github.com/sgraham/40c530073ac70674b263 ...
5 years, 2 months ago (2015-10-23 21:15:43 UTC) #6
Mark Mentovai
5 years, 2 months ago (2015-10-23 21:24:35 UTC) #7
Message was sent while issue was closed.
Yeah, those are safe. I was afraid of the context structs at first, but you’re
getting those from the system headers on Windows, and those are already
disabling C4201.

Powered by Google App Engine
This is Rietveld 408576698