Issue 1421143003: Move webkit_version.h.in from content to build directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1421143003: Move webkit_version.h.in from content to build directory. (Closed)

Created:
5 years, 2 months ago by tfarina

Modified:
5 years, 1 month ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org, jam, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move webkit_version.h.in from content to build directory. This fixes the TODO in build/util/BUILD.gn BUG=None R=brettw@chromium.org Committed: https://crrev.com/f766cab6f0e02f465f35a615f23819a426c817c1 Cr-Commit-Position: refs/heads/master@{#355992}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -11 lines)			Patch
M	build/util/BUILD.gn	View	1 chunk	+1 line, -2 lines	0 comments	Download
A +	build/util/webkit_version.h.in	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	content/content_common.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
D	content/webkit_version.h.in	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

brettw

LGTM. A nice followup would be to move the generated file into target_gen_dir, and then ...

5 years, 2 months ago (2015-10-25 02:37:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421143003/1

5 years, 1 month ago (2015-10-25 13:25:34 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-10-25 14:43:16 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f766cab6f0e02f465f35a615f23819a426c817c1
Cr-Commit-Position: refs/heads/master@{#355992}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages