Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1421133005: Merge to XFA: Revert "One test runner to rule them all." (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Revert "One test runner to rule them all." This reverts commit a1215ba51a235fb7abcb995f0e768ea0176d9275. Revert "Return result of the test runner." This reverts commit d1579c9b92b7f9c1d9e0fac1ecb8e3cb23875fca. Reverting the new test_runner code as there appears to be something string happening on the non-Linux boxes on XFA. It looks like it ran the font_size test twice, once with the .in and once with the .pdf. The .in was suppressed, the .pdf faild and wasn't suppressed. Rendering PDF file /Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf. Rendered 1 pages. Skipped 0 bad pages. Checking /Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf.0.png FAILURE: font_size.in; Command '['/Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/pdfium_diff', '/Volumes/data/b/build/slave/mac_xfa/build/pdfium/testing/resources/pixel/font_size_expected.pdf.0.png', '/Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf.0.png']' returned non-zero exit status 1 font_size.in is suppressed, found in SUPPRESSIONS_mac file Rendering PDF file /Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf. Rendered 1 pages. Skipped 0 bad pages. Checking /Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf.0.png FAILURE: font_size.pdf; Command '['/Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/pdfium_diff', '/Volumes/data/b/build/slave/mac_xfa/build/pdfium/testing/resources/pixel/font_size_expected.pdf.0.png', '/Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf.0.png']' returned non-zero exit status 1 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1410743008 . (cherry picked from commit e067f7bab4317704de27917c1befa8f57a0e78d7) Committed: https://pdfium.googlesource.com/pdfium/+/dccfe5736818f94f7e084105e6d2ab6d5d3a9941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -238 lines) Patch
M testing/tools/run_corpus_tests.py View 1 chunk +155 lines, -3 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 1 chunk +74 lines, -3 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 chunk +86 lines, -3 lines 0 comments Download
D testing/tools/test_runner.py View 1 chunk +0 lines, -229 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dsinclair
TBRing, merge clean.
5 years, 1 month ago (2015-11-03 16:29:56 UTC) #1
dsinclair
Committed patchset #1 (id:1) manually as dccfe5736818f94f7e084105e6d2ab6d5d3a9941 (presubmit successful).
5 years, 1 month ago (2015-11-03 16:30:04 UTC) #2
Lei Zhang
5 years, 1 month ago (2015-11-03 17:00:11 UTC) #3
Message was sent while issue was closed.
whomp whomp lgtm

Powered by Google App Engine
This is Rietveld 408576698