tools/dom/scripts/htmldartgenerator.py - Issue 14211014: Chrome roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 14211014: Chrome roll. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/htmldartgenerator.py

diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py

index 0c351873f3cdd59e14c57d85020532583974979f..06c2cc6d4d20b7b3698eff5065615f60ed96d478 100644

--- a/tools/dom/scripts/htmldartgenerator.py

+++ b/tools/dom/scripts/htmldartgenerator.py

@@ -282,7 +282,7 @@ class HtmlDartGenerator(object):

check = '?%s' % parameter_names[argument_position]

# argument_count instead of argument_position + 1 is used here to cover one

# complicated case with the effectively optional argument in the middle.

- # Consider foo(x, [Optional] y, [Optional=DefaultIsNullString] z)

+ # Consider foo(x, optional y, [Default=NullString] optional z)

# (as of now it's modelled after HTMLMediaElement.webkitAddKey).

# y is optional in WebCore, while z is not.

# In this case, if y was actually passed, we'd like to emit foo(x, y, z) invocation,

« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/scripts/idlnode.py » ('j') | no next file with comments »