src/x64/lithium-codegen-x64.cc - Issue 14211009: Crankshaft: Recognize (i >>> 0) === i for integer32 inputs and replace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 14211009: Crankshaft: Recognize (i >>> 0) === i for integer32 inputs and replace (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

===================================================================

--- src/x64/lithium-codegen-x64.cc (revision 14364)

+++ src/x64/lithium-codegen-x64.cc (working copy)

@@ -1498,11 +1498,15 @@

}

break;

case Token::SHR:

- if (shift_count == 0 && instr->can_deopt()) {

+ if (shift_count != 0) {

+ __ shrl(ToRegister(left), Immediate(shift_count));

+ } else if (instr->can_deopt()) {

__ testl(ToRegister(left), ToRegister(left));

DeoptimizeIf(negative, instr->environment());

} else {

- __ shrl(ToRegister(left), Immediate(shift_count));

+ // Even if the shift is zero, we have to zero out the high bits with

+ // a movl for negative inputs.

+ __ movl(ToRegister(left), ToRegister(left));

}

break;

case Token::SHL:

« no previous file with comments | « src/token.h ('k') | no next file » | no next file with comments »