src/ia32/lithium-codegen-ia32.cc - Issue 14211009: Crankshaft: Recognize (i >>> 0) === i for integer32 inputs and replace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 14211009: Crankshaft: Recognize (i >>> 0) === i for integer32 inputs and replace (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

===================================================================

--- src/ia32/lithium-codegen-ia32.cc (revision 14364)

+++ src/ia32/lithium-codegen-ia32.cc (working copy)

@@ -1692,11 +1692,11 @@

uint8_t shift_count = static_cast<uint8_t>(value & 0x1F);

switch (instr->op()) {

case Token::ROR:

- if (shift_count == 0 && instr->can_deopt()) {

+ if (shift_count != 0) {

+ __ ror(ToRegister(left), shift_count);

+ } else if (instr->can_deopt()) {

__ test(ToRegister(left), Immediate(0x80000000));

DeoptimizeIf(not_zero, instr->environment());

- } else {

- __ ror(ToRegister(left), shift_count);

}

break;

case Token::SAR:

@@ -1705,11 +1705,11 @@

}

break;

case Token::SHR:

- if (shift_count == 0 && instr->can_deopt()) {

+ if (shift_count != 0) {

+ __ shr(ToRegister(left), shift_count);

+ } else if (instr->can_deopt()) {

__ test(ToRegister(left), Immediate(0x80000000));

DeoptimizeIf(not_zero, instr->environment());

- } else {

- __ shr(ToRegister(left), shift_count);

}

break;

case Token::SHL:

« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/token.h » ('j') | no next file with comments »