Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: sdk/lib/_internal/compiler/implementation/scanner/listener.dart

Issue 14211008: Add support for rethrow and start treating throw <expr> as an expression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use ?:. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/scanner/listener.dart
diff --git a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
index e535f62599ec4a49f1bc805bdffb21cbb8197189..6e83386f98016320817b5dae181d5a5407ea3bc1 100644
--- a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
+++ b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
@@ -339,10 +339,13 @@ class Listener {
void endSwitchBlock(int caseCount, Token beginToken, Token endToken) {
}
- void beginThrowStatement(Token token) {
+ void beginThrowExpression(Token token) {
}
- void endThrowStatement(Token throwToken, Token endToken) {
+ void endThrowExpression(Token throwToken, Token endToken) {
+ }
+
+ void beginRethrowStatement(Token token) {
}
void endRethrowStatement(Token throwToken, Token endToken) {
@@ -1580,13 +1583,16 @@ class NodeListener extends ElementListener {
pushNode(new Block(makeNodeList(count, beginToken, endToken, null)));
}
- void endThrowStatement(Token throwToken, Token endToken) {
+ void endThrowExpression(Token throwToken, Token endToken) {
Expression expression = popNode();
pushNode(new Throw(expression, throwToken, endToken));
}
void endRethrowStatement(Token throwToken, Token endToken) {
- pushNode(new Throw(null, throwToken, endToken));
+ pushNode(new Rethrow(throwToken, endToken));
+ if (identical(throwToken.stringValue, 'throw')) {
+ listener.onDeprecatedFeature(throwToken, 'throw without an expression');
+ }
}
void handleUnaryPrefixExpression(Token token) {

Powered by Google App Engine
This is Rietveld 408576698