Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 14211005: [MIPS] Add "mipsel" to kArch in OmahaQueryParams (Closed)

Created:
7 years, 8 months ago by petarj
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[MIPS] Add "mipsel" to kArch in OmahaQueryParams Recent refactoring broke the build for MIPS, since MIPS was not included in kArch. BUG=130022 TEST= make chrome Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195721

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/common/omaha_query_params.cc View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (0 generated)
petarj
7 years, 8 months ago (2013-04-18 16:05:30 UTC) #1
asargent_no_longer_on_chrome
https://codereview.chromium.org/14211005/diff/1/chrome/common/omaha_query_params.cc File chrome/common/omaha_query_params.cc (right): https://codereview.chromium.org/14211005/diff/1/chrome/common/omaha_query_params.cc#newcode43 chrome/common/omaha_query_params.cc:43: "mipsel"; Is it intended that this differs from the ...
7 years, 8 months ago (2013-04-18 21:39:35 UTC) #2
petarj
https://codereview.chromium.org/14211005/diff/1/chrome/common/omaha_query_params.cc File chrome/common/omaha_query_params.cc (right): https://codereview.chromium.org/14211005/diff/1/chrome/common/omaha_query_params.cc#newcode43 chrome/common/omaha_query_params.cc:43: "mipsel"; On 2013/04/18 21:39:35, Antony Sargent wrote: > Is ...
7 years, 8 months ago (2013-04-18 23:39:17 UTC) #3
asargent_no_longer_on_chrome
lgtm
7 years, 8 months ago (2013-04-19 18:11:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/14211005/1
7 years, 8 months ago (2013-04-19 19:17:58 UTC) #5
commit-bot: I haz the power
Presubmit check for 14211005-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-19 19:18:01 UTC) #6
petarj
On 2013/04/19 19:18:01, I haz the power (commit-bot) wrote: Who is the owner of omaha_query_params.cc?
7 years, 8 months ago (2013-04-19 20:03:45 UTC) #7
sky
Rubber stamp LGTM
7 years, 8 months ago (2013-04-22 17:07:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/14211005/1
7 years, 8 months ago (2013-04-22 17:59:21 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=31562
7 years, 8 months ago (2013-04-22 20:58:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/14211005/1
7 years, 8 months ago (2013-04-23 02:09:05 UTC) #11
commit-bot: I haz the power
7 years, 8 months ago (2013-04-23 05:26:07 UTC) #12
Message was sent while issue was closed.
Change committed as 195721

Powered by Google App Engine
This is Rietveld 408576698