Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: chrome/browser/ui/views/tabs/window_finder.h

Issue 1421083003: Introduces window_finder_android.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reviews Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/window_finder.h
diff --git a/chrome/browser/ui/views/tabs/window_finder.h b/chrome/browser/ui/views/tabs/window_finder.h
index 91de6c161da5ee8abd0a969dbdc35f4599a248a4..0ca496070aef9553aaf60c1ea6d264c6a6e97b98 100644
--- a/chrome/browser/ui/views/tabs/window_finder.h
+++ b/chrome/browser/ui/views/tabs/window_finder.h
@@ -18,9 +18,15 @@ class Point;
}
// Returns the Window at the specified point, ignoring the windows in |ignore|.
+// TODO(bshe): |window| is currently only used on Android platform. It is used
sky 2015/11/09 03:35:03 You don't actually document what |window| is. I wo
bshe 2015/11/09 18:25:36 Done.
+// to access root window. Other platforms either do not need root window or can
+// access to ash which could access root window directly by calling
+// ::ash::wm::GetRootWindowAt. Remove |window| once we have a way to get root
+// window from |screen_point| on Android. See crbug.com/549735
gfx::NativeWindow GetLocalProcessWindowAtPoint(
chrome::HostDesktopType host_desktop_type,
const gfx::Point& screen_point,
- const std::set<gfx::NativeWindow>& ignore);
+ const std::set<gfx::NativeWindow>& ignore,
+ gfx::NativeWindow window);
#endif // CHROME_BROWSER_UI_VIEWS_TABS_WINDOW_FINDER_H_

Powered by Google App Engine
This is Rietveld 408576698