Add support for NetBSD (OS = netbsd)

Add support for NetBSD (OS = netbsd)

BUG=
R=dpranke@chromium.org, info@bnoordhuis.nl, thechargingvolcano@gmail.com

Committed: https://chromium.googlesource.com/external/gyp/+/567d084f2cb1d62518a8027dc9cbf1b46f4a523e

[Tom Freudenberg, 2015-11-06 19:01:44]

Description was changed from

==========
Add support for NetBSD (OS = netbsd)

BUG=
==========

to

==========
Add support for NetBSD (OS = netbsd)

BUG=
==========

[Tom Freudenberg, 2015-11-06 19:01:44]

th.freudenberg@googlemail.com changed reviewers:
+ bradnelson@google.com, mark@chromium.org, sbc@chromium.org,
thakis@chromium.org

[Tom Freudenberg, 2015-11-06 19:02:42]

Thanks for reviewing and feedback in advance.

Tom

[noordhuis, 2015-11-11 10:31:12]

info@bnoordhuis.nl changed reviewers:
+ info@bnoordhuis.nl

[noordhuis, 2015-11-11 10:31:13]

LGTM FWIW.  Can an official reviewer PTAL?

[thefourtheye, 2015-11-11 10:42:22]

thechargingvolcano@gmail.com changed reviewers:
+ thechargingvolcano@gmail.com

[thefourtheye, 2015-11-11 10:42:23]

Seems straight forward. LGTM.

[noordhuis, 2015-11-18 17:29:03]

Can an owner PTAL?

[Dirk Pranke, 2015-11-19 02:36:17]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-11-19 02:36:18]

lgtm, though I can't remember if we need to make sure that you've signed the CLA
or not ...

Mark, Brad, do you know?

[Tom Freudenberg, 2015-11-19 03:50:40]

On 2015/11/19 02:36:18, Dirk Pranke wrote:
> lgtm, though I can't remember if we need to make sure that you've signed the
CLA

Hi Dirk, not sure if you are talking about that but I have followed the guide at
https://www.chromium.org/developers/contributing-code

and made already my individual CLA at
https://cla.developers.google.com/about/google-individual?csw=1

when creating this PR

[Mark Mentovai, 2015-11-19 05:13:44]

Yeah, we should make sure to have a CLA on file for all contributions.

[Dirk Pranke, 2015-11-19 05:30:30]

On 2015/11/19 03:50:40, Tom Freudenberg wrote:
> On 2015/11/19 02:36:18, Dirk Pranke wrote:
> > lgtm, though I can't remember if we need to make sure that you've signed the
> CLA
> 
> Hi Dirk, not sure if you are talking about that but I have followed the guide
at
> https://www.chromium.org/developers/contributing-code
> 
> and made already my individual CLA at
> https://cla.developers.google.com/about/google-individual?csw=1
> 
> when creating this PR

Yup, that's what I was talking about. I simply hadn't gotten around to checking.

Thanks!

[Nico, 2015-11-19 05:31:27]

On 2015/11/19 05:30:30, Dirk Pranke wrote:
> On 2015/11/19 03:50:40, Tom Freudenberg wrote:
> > On 2015/11/19 02:36:18, Dirk Pranke wrote:
> > > lgtm, though I can't remember if we need to make sure that you've signed
the
> > CLA
> > 
> > Hi Dirk, not sure if you are talking about that but I have followed the
guide
> at
> > https://www.chromium.org/developers/contributing-code
> > 
> > and made already my individual CLA at
> > https://cla.developers.google.com/about/google-individual?csw=1
> > 
> > when creating this PR
> 
> Yup, that's what I was talking about. I simply hadn't gotten around to
checking.

(I think there's a bot that checks this too these days – at least there used to
be one a few months ago)

[scottmg, 2015-11-19 17:16:43]

On 2015/11/19 05:31:27, Nico (vacation Nov 18-19) wrote:
> On 2015/11/19 05:30:30, Dirk Pranke wrote:
> > On 2015/11/19 03:50:40, Tom Freudenberg wrote:
> > > On 2015/11/19 02:36:18, Dirk Pranke wrote:
> > > > lgtm, though I can't remember if we need to make sure that you've signed
> the
> > > CLA
> > > 
> > > Hi Dirk, not sure if you are talking about that but I have followed the
> guide
> > at
> > > https://www.chromium.org/developers/contributing-code
> > > 
> > > and made already my individual CLA at
> > > https://cla.developers.google.com/about/google-individual?csw=1
> > > 
> > > when creating this PR
> > 
> > Yup, that's what I was talking about. I simply hadn't gotten around to
> checking.
> 
> (I think there's a bot that checks this too these days – at least there
used to
> be one a few months ago)

I think that's in the CQ, so won't help for gyp.

[Tom Freudenberg, 2015-11-19 17:51:39]

On 2015/11/19 17:16:43, scottmg wrote:

> I think that's in the CQ, so won't help for gyp.

Hi Scott, what does CQ mean and what won't help for gyp?

My code or my CLA? Please help if I have to do something, currently not familar
with the process on chromium.

Thanks,
Tom

[Dirk Pranke, 2015-11-19 17:58:23]

On 2015/11/19 17:51:39, Tom Freudenberg wrote:
> On 2015/11/19 17:16:43, scottmg wrote:
> 
> > I think that's in the CQ, so won't help for gyp.
> 
> Hi Scott, what does CQ mean and what won't help for gyp?

CQ stands for "commit queue", and refers to something we have for several
other Chromium projects but not GYP.

It sounds like you're all set. I'll double-check the entry on the CLA later
today and land your patch.

[Tom Freudenberg, 2015-11-19 18:01:01]

On 2015/11/19 17:58:23, Dirk Pranke wrote:

> It sounds like you're all set. I'll double-check the entry on the CLA later
> today and land your patch.

Thanks Dirk! So I will wait until someone ping me for something to do ;-)

[noordhuis, 2015-11-26 21:36:59]

Am I right that this patch hasn't landed yet?

For background, I'm waiting to close out
https://github.com/nodejs/node-gyp/pull/803.

[Dirk Pranke, 2015-11-29 18:45:54]

Description was changed from

==========
Add support for NetBSD (OS = netbsd)

BUG=
==========

to

==========
Add support for NetBSD (OS = netbsd)

BUG=
R=dpranke@chromium.org, info@bnoordhuis.nl, thechargingvolcano@gmail.com

Committed:
https://chromium.googlesource.com/external/gyp/+/567d084f2cb1d62518a8027dc9cb...
==========

[Dirk Pranke, 2015-11-29 18:45:55]

Committed patchset #1 (id:1) manually as
567d084f2cb1d62518a8027dc9cbf1b46f4a523e (presubmit successful).

[Dirk Pranke, 2015-11-29 18:46:26]

I'm sorry for the delay. Landed now.

[Tom Freudenberg, 2015-12-01 06:54:20]

On 2015/11/29 18:46:26, Dirk Pranke wrote:
> I'm sorry for the delay. Landed now.

Hi Dirk, thanks for pulling and commit.

Tom