src/objects.h - Issue 1421033002: [es6] Partially implement Reflect.defineProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 1421033002: [es6] Partially implement Reflect.defineProperty. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address a comment and rebase. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 8466eed21f85ceb786e9549629dc806d9d383f82..67a99005cb31aa815d7339fa9f2e457678c9125d 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -1879,7 +1879,7 @@ class JSReceiver: public HeapObject {

Handle<Object> properties);

// "virtual" dispatcher to the correct [[DefineOwnProperty]] implementation.

- static bool DefineOwnProperty(Isolate* isolate, Handle<JSObject> object,

+ static bool DefineOwnProperty(Isolate* isolate, Handle<JSReceiver> object,

Handle<Object> key, PropertyDescriptor* desc,

ShouldThrow should_throw);

« no previous file with comments | « src/builtins.cc ('k') | src/objects.cc » ('j') | no next file with comments »