Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: components/sync_driver/sync_client.h

Issue 1421003007: [Sync] Componentize ProfileSyncComponentsFactoryImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix browser_tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/sync_client.h
diff --git a/components/sync_driver/sync_client.h b/components/sync_driver/sync_client.h
index fda584dd0cdc6fb64ada9b97545d938096ea3d3f..c6dc2f04dd4568d7ceeb34bccf29d6e22d4a05d6 100644
--- a/components/sync_driver/sync_client.h
+++ b/components/sync_driver/sync_client.h
@@ -10,6 +10,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
+#include "components/sync_driver/sync_api_component_factory.h"
#include "sync/internal_api/public/base/model_type.h"
#include "sync/internal_api/public/engine/model_safe_worker.h"
#include "sync/util/extensions_activity.h"
@@ -53,7 +54,6 @@ class SyncSessionsClient;
namespace sync_driver {
-class SyncApiComponentFactory;
class SyncService;
typedef base::Callback<void(base::Time, base::Time)> ClearBrowsingDataCallback;
@@ -69,10 +69,10 @@ class SyncClient {
SyncClient();
virtual ~SyncClient();
- // Initializes the sync client with the specified sync service. This will also
- // register data type controllers with |service| (via
- // SyncApiComponentFactory::RegisterDataTypes).
- virtual void Initialize(SyncService* service) = 0;
+ // Initializes the sync client with the specified sync api component factory
+ // and sync service.
+ virtual void Initialize(scoped_ptr<SyncApiComponentFactory> factory,
+ SyncService* service) = 0;
// Returns the current SyncService instance.
virtual SyncService* GetSyncService() = 0;
@@ -90,6 +90,11 @@ class SyncClient {
// have browsing data cleared.
virtual ClearBrowsingDataCallback GetClearBrowsingDataCallback() = 0;
+ // Returns a callback that will register the types specific to the current
+ // platform.
+ virtual sync_driver::SyncApiComponentFactory::RegisterDataTypesMethod
+ GetRegisterPlatformTypesCallback() = 0;
+
// Returns a callback that will be invoked when password sync state has
// potentially been changed.
virtual base::Closure GetPasswordStateChangedCallback() = 0;

Powered by Google App Engine
This is Rietveld 408576698