chrome/browser/extensions/api/sessions/sessions_apitest.cc - Issue 1421003007: [Sync] Componentize ProfileSyncComponentsFactoryImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_apitest.cc

Issue 1421003007: [Sync] Componentize ProfileSyncComponentsFactoryImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Have ChromeSyncClient create its own SyncApiComponentFactory Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc ('k') | chrome/browser/sync/chrome_sync_client.h » ('j') | chrome/browser/sync/chrome_sync_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sessions/sessions_apitest.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_apitest.cc b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

index 29990032ab0f71efb8734625e37d309c09c4cc9a..08d4b2ae2b15154aa385537dba51ab39400a8412 100644

--- a/chrome/browser/extensions/api/sessions/sessions_apitest.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

@@ -137,10 +137,13 @@ scoped_ptr<KeyedService> ExtensionSessionsTest::BuildProfileSyncService(

sync_pb::SyncEnums_DeviceType_TYPE_LINUX,

"device_id")));

- return make_scoped_ptr(new ProfileSyncServiceMock(

- make_scoped_ptr(new browser_sync::ChromeSyncClient(

- static_cast<Profile*>(context), factory.Pass())),

- static_cast<Profile*>(context)));

+ Profile* profile = static_cast<Profile*>(context);

+ ProfileSyncServiceMock* sync_service = new ProfileSyncServiceMock(

+ make_scoped_ptr(new browser_sync::ChromeSyncClient(profile)), profile);

+ static_cast<browser_sync::ChromeSyncClient*>(sync_service->GetSyncClient())

+ ->SetSyncApiComponentFactoryForTesting(

+ make_scoped_ptr(new SyncApiComponentFactoryMock()));

+ return make_scoped_ptr(sync_service);

}

void ExtensionSessionsTest::CreateTestProfileSyncService() {