Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5231)

Unified Diff: chrome/browser/sync/profile_sync_service_factory.cc

Issue 1421003007: [Sync] Componentize ProfileSyncComponentsFactoryImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_factory.cc
diff --git a/chrome/browser/sync/profile_sync_service_factory.cc b/chrome/browser/sync/profile_sync_service_factory.cc
index 1478dc352e9ed5cff20009ca2bab196ef78cd6f8..70ffd07fb45e9c274ed8bf6a9d2094bcc4e20cd8 100644
--- a/chrome/browser/sync/profile_sync_service_factory.cc
+++ b/chrome/browser/sync/profile_sync_service_factory.cc
@@ -25,11 +25,12 @@
#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/sync/chrome_sync_client.h"
-#include "chrome/browser/sync/profile_sync_components_factory_impl.h"
#include "chrome/browser/sync/supervised_user_signin_manager_wrapper.h"
#include "chrome/browser/themes/theme_service_factory.h"
#include "chrome/browser/web_data_service_factory.h"
#include "chrome/common/channel_info.h"
+#include "chrome/common/pref_names.h"
+#include "components/browser_sync/browser/profile_sync_components_factory_impl.h"
#include "components/browser_sync/browser/profile_sync_service.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
#include "components/network_time/network_time_tracker.h"
@@ -40,6 +41,7 @@
#include "components/sync_driver/sync_util.h"
#include "components/variations/variations_associated_data.h"
#include "content/public/browser/browser_thread.h"
+#include "ui/base/device_form_factor.h"
#include "url/gurl.h"
#if defined(ENABLE_EXTENSIONS)
@@ -163,7 +165,6 @@ KeyedService* ProfileSyncServiceFactory::BuildServiceInstanceFor(
scoped_ptr<SigninManagerWrapper> signin_wrapper(
new SupervisedUserSigninManagerWrapper(profile, signin));
- std::string account_id = signin_wrapper->GetAccountIdToUse();
OAuth2TokenService::ScopeSet scope_set;
scope_set.insert(signin_wrapper->GetSyncScopeToUse());
ProfileOAuth2TokenService* token_service =
@@ -180,9 +181,27 @@ KeyedService* ProfileSyncServiceFactory::BuildServiceInstanceFor(
browser_sync::ProfileSyncServiceStartBehavior behavior =
browser_defaults::kSyncAutoStarts ? browser_sync::AUTO_START
: browser_sync::MANUAL_START;
+ ProfileSyncComponentsFactoryImpl::RegisterDataTypesMethod
+ register_platform_types_callback = base::Bind(
+#ifdef OS_ANDROID
+ &browser_sync::ChromeSyncClient::RegisterAndroidDataTypes, profile
+#else
+ &browser_sync::ChromeSyncClient::RegisterDesktopDataTypes, profile
+#endif // OS_ANDROID
+ );
scoped_ptr<sync_driver::SyncApiComponentFactory> sync_factory(
new ProfileSyncComponentsFactoryImpl(
- profile, base::CommandLine::ForCurrentProcess(), sync_service_url,
+ register_platform_types_callback,
+ chrome::GetChannel(),
+ chrome::GetVersionString(),
+ ui::GetDeviceFormFactor() == ui::DEVICE_FORM_FACTOR_TABLET,
+ *base::CommandLine::ForCurrentProcess(),
+ prefs::kSavingBrowserHistoryDisabled,
+ sync_service_url,
+ content::BrowserThread::GetMessageLoopProxyForThread(
+ content::BrowserThread::UI),
+ content::BrowserThread::GetMessageLoopProxyForThread(
+ content::BrowserThread::DB),
token_service, url_request_context_getter));
scoped_ptr<browser_sync::ChromeSyncClient> sync_client(
new browser_sync::ChromeSyncClient(profile, sync_factory.Pass()));

Powered by Google App Engine
This is Rietveld 408576698