[Sync] Componentize ProfileSyncComponentsFactoryImpl

components/browser_sync/browser/profile_sync_components_factory_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
-#define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
+#ifndef COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
+#define COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/memory/weak_ptr.h"
 #include "components/sync_driver/sync_api_component_factory.h"
+#include "components/version_info/version_info.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "url/gurl.h"
 
 class OAuth2TokenService;
 class Profile;
 
-namespace base {
-class CommandLine;
-}
-
 namespace net {
 class URLRequestContextGetter;
 }
 
 class ProfileSyncComponentsFactoryImpl
     : public sync_driver::SyncApiComponentFactory {
  public:
+  // Callback to allow platform-specific datatypes to register themselves as
+  // data type controllers.
+  // |disabled_types| and |enabled_types| control the disable/enable state of
+  // types that or on or off by default (respectively).

[blundell, 2015/11/10 15:24:25]

or on -> are on

[Nicolas Zea, 2015/11/11 00:06:20]

Done.

+  typedef base::Callback<void(syncer::ModelTypeSet disabled_types,
+                              syncer::ModelTypeSet enabled_types,
+                              sync_driver::SyncClient* sync_client)>
+      RegisterDataTypesMethod;
+
   // Constructs a ProfileSyncComponentsFactoryImpl.
   //
   // |sync_service_url| is the base URL of the sync server.
   //
   // |token_service| must outlive the ProfileSyncComponentsFactoryImpl.
   //
   // |url_request_context_getter| must outlive the
   // ProfileSyncComponentsFactoryImpl.
   ProfileSyncComponentsFactoryImpl(
-      Profile* profile,
-      base::CommandLine* command_line,
+      const RegisterDataTypesMethod& register_platform_types_method,
+      version_info::Channel channel,
+      const std::string& version,
+      bool is_tablet,
+      const base::CommandLine& command_line,
+      const std::string& history_disabled_pref,
       const GURL& sync_service_url,
+      const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,
+      const scoped_refptr<base::SingleThreadTaskRunner>& db_thread,
       OAuth2TokenService* token_service,
       net::URLRequestContextGetter* url_request_context_getter);
   ~ProfileSyncComponentsFactoryImpl() override;
 
   void RegisterDataTypes(sync_driver::SyncClient* sync_client) override;
 
   sync_driver::DataTypeManager* CreateDataTypeManager(
       const syncer::WeakHandle<syncer::DataTypeDebugInfoListener>&
           debug_info_listener,
       const sync_driver::DataTypeController::TypeMap* controllers,
@@ skipping 23 matching lines @@
   CreateBookmarkSyncComponents(
       sync_driver::SyncService* sync_service,
       sync_driver::DataTypeErrorHandler* error_handler) override;
   sync_driver::SyncApiComponentFactory::SyncComponents
   CreateTypedUrlSyncComponents(
       sync_driver::SyncService* sync_service,
       history::HistoryBackend* history_backend,
       sync_driver::DataTypeErrorHandler* error_handler) override;
 
  private:
-  // Register data types which are enabled on desktop platforms only.
-  // |disabled_types| and |enabled_types| correspond only to those types
-  // being explicitly enabled/disabled by the command line.
-  void RegisterDesktopDataTypes(syncer::ModelTypeSet disabled_types,
-                                syncer::ModelTypeSet enabled_types,
-                                sync_driver::SyncClient* sync_client);
-
   // Register data types which are enabled on both desktop and mobile.
   // |disabled_types| and |enabled_types| correspond only to those types
   // being explicitly enabled/disabled by the command line.
   void RegisterCommonDataTypes(syncer::ModelTypeSet disabled_types,
                                syncer::ModelTypeSet enabled_types,
                                sync_driver::SyncClient* sync_client);
 
   void DisableBrokenType(syncer::ModelType type,
                          const tracked_objects::Location& from_here,
                          const std::string& message);
 
-  Profile* profile_;
-  base::CommandLine* command_line_;
-
+  // Client/platform specific members.
+  const RegisterDataTypesMethod register_platform_types_method_;
+  const version_info::Channel channel_;
+  const std::string version_;
+  const bool is_tablet_;
+  const base::CommandLine command_line_;
+  const std::string history_disabled_pref_;

[blundell, 2015/11/10 15:24:25]

nit: So far we've been keeping this as a const char*. Seems like it's worth
having consistency?

[Nicolas Zea, 2015/11/11 00:06:20]

Done.

   const GURL sync_service_url_;
+  const scoped_refptr<base::SingleThreadTaskRunner> ui_thread_;
+  const scoped_refptr<base::SingleThreadTaskRunner> db_thread_;
   OAuth2TokenService* const token_service_;
   net::URLRequestContextGetter* const url_request_context_getter_;
 
   base::WeakPtrFactory<ProfileSyncComponentsFactoryImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl);
 };
 
-#endif  // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
+#endif  // COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__