pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart - Issue 1421003004: Add CoreClasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

Issue 1421003004: Add CoreClasses (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comment. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart b/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

index 40bebf30b2de5364df3ddd73abef4ffeb90171bd..3a84f11dd7c7bca311bc6455e391692956c3e705 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

@@ -165,6 +165,6 @@ class FieldVisitor {

// We never generate accessors for top-level/static fields.

if (!member.isInstanceMember) return true;

DartType type = member.type;

- return type.treatAsDynamic || (type.element == compiler.objectClass);

+ return type.treatAsDynamic || type.isObject;

}