Issue 14210005: [NaCl SDK] Fix linux_nacl_sdk trybot -- it needs to clear http_proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14210005: [NaCl SDK] Fix linux_nacl_sdk trybot -- it needs to clear http_proxy. (Closed)

Created:
7 years, 8 months ago by binji

Modified:
7 years, 8 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Fix linux_nacl_sdk trybot -- it needs to clear http_proxy. BUG=229470 R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194385

Patch Set 3 : feedback #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	native_client_sdk/src/build_tools/build_sdk.py	View	1 2	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

lgtm https://codereview.chromium.org/14210005/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/14210005/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode814 native_client_sdk/src/build_tools/build_sdk.py:814: env['http_proxy'] = '' how about delete it rather ...

7 years, 8 months ago (2013-04-16 00:39:37 UTC) #2

binji

7 years, 8 months ago (2013-04-16 17:40:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r194385 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14210005: [NaCl SDK] Fix linux_nacl_sdk trybot -- it needs to clear http_proxy. (Closed)

Description

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : feedback #

Messages